8000 feat(anta.cli): Add possibility to render multiple examples for the same test by gmuloc · Pull Request #1098 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.cli): Add possibility to render multiple examples for the same test #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

feat(anta.cli): Add possibility to render multiple examples for the same test #1098

merged 1 commit into from
Mar 13, 2025

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Mar 13, 2025

Description

Fixes #1097

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc requested a review from vitthalmagadum March 13, 2025 09:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #1098 will not alter performance

Comparing gmuloc:feat/1097 (fc3cff2) with main (f841d66)

Summary

✅ 22 untouched benchmarks

carl-baillargeon
carl-baillargeon approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 14a98e3 into aristanetworks:main Mar 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum Awaiting requested review from vitthalmagadum

Assignees

@gmuloc gmuloc

Labels
rn: feat(anta.cli)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement(anta.tests): Generate examples/tests.yaml to Include Multiple Examples in Docstrings
2 participants
@gmuloc @carl-baillargeon
0