8000 feat(anta.tests): Added VerifyPhysicalInterfacesCounterDetails test by geetanjalimanegslab · Pull Request #1188 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.tests): Added VerifyPhysicalInterfacesCounterDetails test #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 20, 2025
Merged

feat(anta.tests): Added VerifyPhysicalInterfacesCounterDetails test #1188

merged 29 commits into from
Jun 20, 2025
+799 −8

Conversation

geetanjalimanegslab
Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab commented May 5, 2025 •
edited
Loading

Description

Added test VerifyInterfacesCounters to support all interface errors with expected threshold

Added test changes -
1. interfaces_errors_and_discards_test.py
2. interfaces_mgmt_only_test.py

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@geetanjalimanegslab
feat(anta.tests): Updated test VerifyInterfaceErrors and VerifyInterf…
f99e19b 
…aceDiscards to support all interface errors with expected threshold
@geetanjalimanegslab geetanjalimanegslab self-assigned this May 5, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1188 will not alter performance

Comparing geetanjalimanegslab:issue_int_erros (d3d58f1) with main (79d38e5)

Summary

✅ 26 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

8000 @geetanjalimanegslab geetanjalimanegslab changed the title feat(anta.tests): Updated test VerifyInterfaceErrors and VerifyInterfaceDiscards to support all interface errors with expected threshold feat(anta.tests): Added test VerifyInterfacesCounters to support all interface errors with expected threshold May 20, 2025
vitthalmagadum
vitthalmagadum requested changes May 21, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum vitthalmagadum marked this pull request as ready for review June 4, 2025 10:33
@vitthalmagadum vitthalmagadum self-requested a review June 4, 2025 10:33
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon requested changes Jun 18, 2025
View reviewed changes
This was referenced Jun 18, 2025
Merged
Merged
Merged
Open
carl-baillargeon
carl-baillargeon requested changes Jun 19, 2025
View reviewed changes
carl-baillargeon
carl-baillargeon approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@carl-baillargeon carl-baillargeon changed the title feat(anta.tests): Added test VerifyInterfacesCounters to support all interface errors with expected threshold feat(anta.tests): Added VerifyPhysicalInterfacesCounterDetails test Jun 20, 2025
@carl-baillargeon carl-baillargeon merged commit 38ef07c into aristanetworks:main Jun 20, 2025
21 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: feat(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geetanjalimanegslab @carl-baillargeon @vitthalmagadum
0