10000 refactor(anta): Special characters from failure messages should be escaped properly in Markdown by vitthalmagadum · Pull Request #1191 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(anta): Special characters from failure messages should be escaped properly in Markdown #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

refactor(anta): Special characters from failure messages should be escaped properly in Markdown #1191

merged 1 commit into from
May 7, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Special characters from failure messages should be escaped properly in Markdown

Fixes #1090

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 7, 2025

CodSpeed Performance Report

Merging #1191 will not alter performance

Comparing vitthalmagadum:feat/escape-backtick (c815d6d) with main (b2bd860)

Summary

✅ 22 untouched benchmarks

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

geetanjalimanegslab
geetanjalimanegslab approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmuloc
gmuloc reviewed May 7, 2025
View reviewed changes
carl-baillargeon
carl-baillargeon approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmuloc gmuloc merged commit 71e2889 into aristanetworks:main May 7, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@geetanjalimanegslab geetanjalimanegslab geetanjalimanegslab approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special characters from failure messages should be escaped properly in Markdown
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @geetanjalimanegslab
0