8000 fix(anta.tests): Fix VerifyInterfaceUtilization and other interface tests to support subinterfaces by carl-baillargeon · Pull Request #1231 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(anta.tests): Fix VerifyInterfaceUtilization and other interface tests to support subinterfaces #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

fix(anta.tests): Fix VerifyInterfaceUtilization and other interface tests to support subinterfaces #1231

merged 4 commits into from
Jun 2, 2025
+193 −1,371

Conversation

carl-baillargeon
Copy link
Contributor

Description

  • Refactor VerifyInterfaceUtilization to use show interfaces status instead of show interfaces to fetch each interface bandwidth and duplex mode.
  • Clean VerifyInterfaceUtilization unit tests and add various scenarios
  • Update all interface tests to use separator=".." in get_value to properly fetch the subinterfaces

Fixes #1230

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1231 will not alter performance

Comparing carl-baillargeon:fix/issue_1230 (79be89f) with main (669660d)

Summary

✅ 26 untouched benchmarks

@carl-baillargeon carl-baillargeon changed the title fix(anta.tests): Fix VerifyInterfaceUtilization to support subinterfaces fix(anta.tests): Fix VerifyInterfaceUtilization and other interface tests to support subinterfaces Jun 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jun 2, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vitthalmagadum
vitthalmagadum approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator
@vitthalmagadum vitthalmagadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 26a4da4 into aristanetworks:main Jun 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(anta.tests): VerifyInterfaceUtilization doesn't support subinterfaces
2 participants
@carl-baillargeon @vitthalmagadum
0