8000 feat(anta): Update default logging behavior by titom73 · Pull Request #132 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Update default logging behavior #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

feat(anta): Update default logging behavior #132

merged 3 commits into from
Jan 25, 2023

Conversation

titom73
Copy link
Contributor
@titom73 titom73 commented Jan 12, 2023

Update default logging behaviour to not list all tests addition in result manager by default

  • Configure INFO only for check-devices.py script
  • Configure WARNING for anta.inventory module
  • Configure WARNING for anta.result_manager module

To change logging for anta.inventory & anta.result_manager, --loglevel option can be used

@titom73 titom73 requested a review from mtache January 12, 2023 08:45
gmuloc
gmuloc reviewed Jan 12, 2023
View reviewed changes
@titom73 titom73 marked this pull request as ready for review January 12, 2023 12:59
@titom73 titom73 requested a review from gmuloc January 12, 2023 12:59
gmuloc
gmuloc reviewed Jan 12, 2023
View reviewed changes
gmuloc
gmuloc approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator
@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though people may wonder what "other" loggers are which are configured to WARNING and CRITICAL by default :) (and looks like most of them are actually ERROR no?)

@titom73 titom73 merged commit 9bb7af2 into aristanetworks:master Jan 25, 2023
@titom73 titom73 changed the title feat(check-devices): Update default logging behavior feat(anta): Update default logging behavior Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@mtache mtache Awaiting requested review from mtache 5508

Assignees

@titom73 titom73

Labels
rn: feat(anta) Scripts enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @gmuloc
0