8000 chore: Move data to pyproject.toml by gmuloc · Pull Request #137 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Move data to pyproject.toml #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 13, 2023
Merged

chore: Move data to pyproject.toml #137

merged 6 commits into from
Feb 13, 2023

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Feb 9, 2023
  • Prepare for upload to PIP
  • Version bumped to 0.4.0 for now
  • Simplify tox run (run linting and typing only once)

@gmuloc
Chore: Move data to pyproject.toml
9416c8f 
* Prepare for upload to PIP
* Version bumped to 0.4.0 for now
* Simplify tox run (run linting and typing only once)
@gmuloc gmuloc requested review from mtache and titom73 and removed request for mtache February 9, 2023 17:35
@titom73 titom73 added the framework-enhancement New feature or request label Feb 10, 2023
@titom73
Copy link
Contributor
titom73 commented Feb 10, 2023

Looks good using pip install . and tox -e lint

But, we cannot install using -e option to be in editable during development process

root@9cdd90febc39:/tmp# pip list | grep setuptools
setuptools         67.2.0

root@9cdd90febc39:/tmp# pip install -e .
Obtaining file:///tmp
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
ERROR: Project file:///tmp has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. 
Since it does not have a 'setup.py' nor a 'setup.cfg', it cannot be installed in editable mode. 
Consider using a build backend that supports PEP 660.

@gmuloc
Chore: Edit pyproject.toml to avoid setuptool failure
108dc84 
* When another python-ish package is detected by pip during editable
  install it can fail
@gmuloc
CI: Test
304879f
@gmuloc
Fix: Typo
315f7c4
@gmuloc
Chore: Fix pyproject.toml
3175d5f
titom73
titom73 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor
@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit a9647fb into aristanetworks:master Feb 13, 2023
@titom73 titom73 changed the title Chore: Move data to pyproject.toml chore: Move data to pyproject.toml Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@mtache mtache Awaiting requested review from mtache

Assignees

@gmuloc gmuloc

Labels
framework-enhancement New feature or request rn: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmuloc @titom73
0