8000 fix(anta.cli): Improve 'anta exec snapshot' by mtache · Pull Request #166 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(anta.cli): Improve 'anta exec snapshot' #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2023
Merged

fix(anta.cli): Improve 'anta exec snapshot' #166

merged 3 commits into from
Apr 21, 2023

Conversation

mtache
Copy link
Collaborator
@mtache mtache commented Apr 5, 2023 •
edited
Loading
  • Modified collect_commands() logic to use asyncio.gather() instead of the synchronous logic with a for loop.
  • The --output-directory option of the anta exec snapshot command could be None if not provided and created a folder with that name. Added a default value and a timestamp to avoid overriding previous command collections.

@mtache mtache changed the title fix(anta.cli) Improve 'anta exec snapshot' fix(anta.cli): Improve 'anta exec snapshot' Apr 5, 2023
@titom73 titom73 added the Anta CLI All things around CLI label Apr 5, 2023
@titom73 titom73 mentioned this pull request Apr 6, 2023
Merged
@titom73 titom73 self-requested a review April 21, 2023 10:21
titom73
titom73 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor
@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtache mtache merged commit 21defaa into aristanetworks:master Apr 21, 2023
@mtache mtache deleted the fix/snapshot branch June 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

Assignees

@mtache mtache

Labels
Anta CLI All things around CLI rn: fix(anta.cli)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtache @titom73
0