feat: Implement returning error code to anta functions #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
mtache
requested changes
Jul 4, 2023
anta/cli/__init__.py
Outdated
| @@ -55,11 +55,15 @@ | |||
| ), | |||
| callback=setup_logging, | |||
| ) | |||
| @click.option("--ignore-status", show_envvar=True, default=False, help="Always exit with success", is_eager=True) | |||
| @click.option("--ignore-error", show_envvar=True, default=False, help="Only report failures and not errors", is_eager=True) | |||
| def anta(ctx: click.Context, inventory: AntaInventory, **kwargs: Dict[str, Any]) -> None: | |||
There was a problem hiding this comment.
Possible to do that:
Suggested change
| def anta(ctx: click.Context, inventory: AntaInventory, **kwargs: Dict[str, Any]) -> None: | |
| def anta(ctx: click.Context, inventory: AntaInventory, ignore_status: bool, ignore_error: bool, **kwargs: Dict[str, Any]) -> None: |
anta/cli/__init__.py
Outdated
| @@ -55,11 +55,15 @@ | |||
| ), | |||
| callback=setup_logging, | |||
| ) | |||
| @click.option("--ignore-status", show_envvar=True, default=False, help="Always exit with success", is_eager=True) | |||
There was a problem hiding this comment.
is_eager is not needed here.
Also, defining options like this means you wants a boolean as parameter.
anta --help
--ignore-status BOOLEAN Always exit with success [env var:
ANTA_IGNORE_STATUS]
--ignore-error BOOLEAN Only report failures and not errors [env
var: ANTA_IGNORE_ERROR]
You need
Suggested change
| @click.option("--ignore-status", show_envvar=True, default=False, help="Always exit with success", is_eager=True) | |
| @click.option("--ignore-status", is_flag=True, show_envvar=True, default=False, help="Always exit with success") |
Could you also update the insecure flag with the is_flag=True param ?
mtache
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 (even if apparently I can't even name my branches right!)
Behavior tested locally with the various new CLI flags