8000 feat(anta.cli): added latest option to collect-tech-support by mtache · Pull Request #214 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.cli): added latest option to collect-tech-support #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2023
Merged

feat(anta.cli): added latest option to collect-tech-support #214

merged 6 commits into from
Jun 11, 2023

Conversation

mtache
Copy link
Collaborator
@mtache mtache commented Jun 8, 2023 •
edited
Loading

Fixes #198

@mtache mtache linked an issue Jun 8, 2023 that may be closed by this pull request
collect tech-support files #198
Closed
@mtache mtache added framework-enhancement New feature or request Anta CLI All things around CLI labels Jun 8, 2023
carl-baillargeon
carl-baillargeon approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested a few scenarios locally with 1-2-3 files.

titom73
titom73 suggested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor
@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice option! Maybe we should update doc section to reflect this new option ?

@mtache mtache requested a review from titom73 June 9, 2023 13:31
titom73
titom73 approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor
@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship It !

@titom73 titom73 merged commit 07259c0 into aristanetworks:master Jun 11, 2023
@mtache mtache deleted the feat/latest-show-tech branch June 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@mtache mtache

Labels
Anta CLI All things around CLI framework-enhancement New feature or request rn: feat(anta.cli)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collect tech-support files
3 participants
@mtache @titom73 @carl-baillargeon
0