8000 Added Search API functionality by hzargar2 · Pull Request #414 · arlyon/async-stripe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Search API functionality #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 31, 2023
Merged

Added Search API functionality #414

merged 16 commits into from
Oct 31, 2023

Conversation

hzargar2
Copy link
Contributor
@hzargar2 hzargar2 commented Jul 24, 2023 •
edited
Loading

Summary

Added Stripe's Search API functionality for charge, customer, invoice, payment_intent, price, product, and subscription.

Checklist

@codecov
Copy link
codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #414 (b54a4e5) into master (3dd6fec) will decrease coverage by 0.03%.
Report is 11 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head b54a4e5 differs from pull request most recent head 0298de5. Consider uploading reports for the commit 0298de5 to get more accurate results

@@            Coverage Diff            @@
##           master    #414      +/-   ##
=========================================
- Coverage    5.85%   5.82%   -0.03%     
=========================================
  Files         146     146              
  Lines       22573   22671      +98     
=========================================
  Hits         1321    1321              
- Misses      21252   21350      +98
Files Changed Coverage Δ
src/params.rs 58.85% <0.00%> (-20.35%) ⬇️
src/resources/charge_ext.rs 0.00% <0.00%> (ø)
src/resources/customer_ext.rs 0.00% <0.00%> (ø)
src/resources/invoice_ext.rs 0.00% <0.00%> (ø)
src/resources/payment_intent_ext.rs 0.00% <0.00%> (ø)
src/resources/subscription_ext.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arlyon
Copy link
Owner
arlyon commented Jul 26, 2023

Thanks for this, going to make some time to review this properly very soon :)

@arlyon
Copy link
Owner
arlyon commented Aug 19, 2023 •
edited
Loading

could you please mark one of the commits with the feat: prefix and I will merge after you address the comment

arlyon
arlyon requested changes Aug 19, 2023
View reviewed changes
@hzargar2
feat: updated ListPaginator to be generic over type T where T impl Pa…
411f82c 
…ginableList instead of having separate SearchListPaginator and ListPaginator implementations for types SearchList and List.
@hzargar2
feat: fixed mutability
5ad76c5
@hzargar2
feat: fixed warnings
e0d0bd8
@hzargar2
Copy link
Contributor Author
hzargar2 commented Aug 19, 2023 •
edited
Loading

@arlyon Hi, is there a issue with the CI jobs? Some checks seem to fail but the error is not precise. I don't think the error is from my code. Says async-stripe fails to compile but it compiles locally on my machine.

@arlyon
Copy link
Owner
arlyon commented Sep 5, 2023

Hi! We have in fact been having issues due to cargo-llvm-cov. I have ripped it out. Please rebase for me and I'll have another look.

@hzargar2
Copy link
Contributor Author
hzargar2 commented Sep 5, 2023 •
edited
Loading

Hi! We have in fact been having issues due to cargo-llvm-cov. I have ripped it out. Please rebase for me and I'll have another look.

@arlyon I've rebased it however, I am not sure if I did it correctly as I am also not very familiar with git. Please let me if there are any issues. Thanks.

@hzargar2
Copy link
Contributor Author

@arlyon I know you might be busy but is there any update on this? I see it says there is a change requested above which I implemented. Is there anything else you need form my end? Thanks.

@arlyon arlyon merged commit d9d4ecd into arlyon:master Oct 31, 2023
@arlyon
Copy link
Owner
arlyon commented Oct 31, 2023

Merged, thanks for taking the time, and your patience :)

@mzeitlin11 mzeitlin11 mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzargar2 @arlyon
0