chore: some renames and just moving help links into own component #15640
Conversation
#2983 Bundle Size — 8.92MiB (~+0.01%).2441e5b(current) vs 921a975 main#2982(baseline) Warning Bundle contains 18 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch oxaudo/ship Project dashboard Generated by RelativeCI Documentation Report issue |
| @@ -26,7 +28,7 @@ export const Order2DetailsPaymentInfo: React.FC<Props> = ({ order }) => { | |||
|
|
|||
| return ( | |||
| <Box p={2} backgroundColor="mono0"> | |||
| <Text variant="sm" fontWeight={500} color="mono100"> | |||
| <Text variant="sm" fontWeight={700} color="mono100"> | |||
There was a problem hiding this comment.
I don't (think) we ever explicitly set the fontWeight like this; rather its just fontWeight='bold'
There was a problem hiding this comment.
Yea - we were looking at it and bold might work as well but it's 800 weight. 700 looks better in this context. Not a strong opinion though.... It works either way.
There was a problem hiding this comment.
Ah... Never mind. Double checking the spec - and 700 is Bold. Will update:)
There was a problem hiding this comment.
Cool thanks @oxaudo 👍 Regarding figma -- best to lean more closely to existing code patterns, vs careful analysis of the figma since sometimes designers don't exactly align to our design sys. Only reason I flagged this was because i've never seen a numeric fontWeight used before! So it felt like a snowflake addition, even if it might be technically specific in the Figma file.
There was a problem hiding this comment.
Hmm maybe my fault, i did this the same way on checkout because i was copying css values from figma designs.
There was a problem hiding this comment.
Perhaps easier said than done, but would always encourage eye-balling visual stuff and implementing by hand vs any direct copy / paste interaction with Figma. Palette is simple enough, and most things are just looking at the text variant and noticing spacing / margins / paddings. (again, easier said than done tho 😄)
|
Looks like this: |
|
Merging this update so we can see latest on staging. |
Changes here are mostly cosmetic to fix some unclear naming and move some code into own component so that it's easier to do responsive stuff.