8000 Fix missing error check in set_clo_on_exec for FD_CLOEXEC handling by tomasandroil · Pull Request #117 · arun11299/cpp-subprocess · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing error check in set_clo_on_exec for FD_CLOEXEC handling #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Fix missing error check in set_clo_on_exec for FD_CLOEXEC handling #117

merged 1 commit into from
Apr 28, 2025

Conversation

tomasandroil
Copy link
Contributor

Changes:

  • Replaces unchecked fcntl(fd, F_SETFD, flags); with a version that checks the return value.
  • Throws OSError on failure with an appropriate error message.

Motivation:

Proper error handling is critical in system-level code to avoid silent failures, especially when setting file descriptor flags like FD_CLOEXEC. This fix ensures robustness and helps catch configuration issues early during process setup.

Test coverage

No functional change beyond improved error propagation, but this section of code is indirectly exercised by any subprocess-related integration or functional tests. Consider adding a unit test for set_clo_on_exec in the future for completeness.

@tomasandroil
fix(subprocess): check and handle fcntl(F_GETFD) failure
10000
7127931 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.
@tomasandroil tomasandroil mentioned this pull request Apr 28, 2025
Closed
@arun11299 arun11299 merged commit 9974ff6 into arun11299:master Apr 28, 2025
@arun11299
Copy link
Owner

Thank you @tomasandroil

hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Apr 28, 2025
@tomasandroil @hebasto
subprocess: check and handle fcntl(F_GETFD) failure
7e80030 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 9974ff69cdd5fc1a2722cb63f006df9308628b35
@hebasto hebasto mentioned this pull request Apr 28, 2025
Merged
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request May 1, 2025
@tomasandroil @hebasto
subprocess: check and handle fcntl(F_GETFD) failure
cd95c9d 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 9974ff69cdd5fc1a2722cb63f006df9308628b35
hebasto added a commit to bitcoin/bitcoin that referenced this pull request May 5, 2025
@hebasto
Merge #32358: subprocess: Backport upstream changes
53ccb75 
cd95c9d subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)
b7288de subprocess: Proper implementation of wait() on Windows (Haowen Liu)
7423214 subprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)
bb9ffea subprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)
174bd43 subprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)
7997b76 subprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)
6476304 subprocess: Get Windows return code in wait() (Haowen Liu)
d3f511b subprocess: Fix string_arg when used with rref (Haowen Liu)
2fd3f2f subprocess: Fix memory leaks (Haoran Peng)

Pull request description:

  Most of these changes were developed during work on #29868 and #32342 and have since been upstreamed.

  As they are now merged, this PR backports them to our `src/util/subprocess.h` header.

  Required for #29868.

  A list of the backported PRs:
   - arun11299/cpp-subprocess#106
  - arun11299/cpp-subprocess#110
  - arun11299/cpp-subprocess#109
  - arun11299/cpp-subprocess#99
  - arun11299/cpp-subprocess#112
  - arun11299/cpp-subprocess#107
  - arun11299/cpp-subprocess#113
  - arun11299/cpp-subprocess#116
  - arun11299/cpp-subprocess#117

  The following PRs were skipped for backporting:
  - arun11299/cpp-subprocess#108 because we are not planning to support this feature.
  - arun11299/cpp-subprocess#101 because that change has been already landed in #29849.

ACKs for top commit:
  theStack:
    Light ACK cd95c9d
  laanwj:
    Code review re-ACK cd95c9d

Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
w0xlt pushed a commit to w0xlt/bitcoin that referenced this pull request May 7, 2025
@tomasandroil @w0xlt
subprocess: check and handle fcntl(F_GETFD) failure
1a20740 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 9974ff69cdd5fc1a2722cb63f006df9308628b35
alexanderwiederin pushed a commit to alexanderwiederin/bitcoin that referenced this pull request May 8, 2025
@tomasandroil @alexanderwiederin
subprocess: check and handle fcntl(F_GETFD) failure
09b1314 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 997
8000
4ff69cdd5fc1a2722cb63f006df9308628b35
Eunovo pushed a commit to Eunovo/bitcoin that referenced this pull request May 12, 2025
@tomasandroil @Eunovo
subprocess: check and handle fcntl(F_GETFD) failure
53cff29 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 9974ff69cdd5fc1a2722cb63f006df9308628b35
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Jun 6, 2025
@tomasandroil @luke-jr
subprocess: check and handle fcntl(F_GETFD) failure
4f233ac 
Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec.
Raise OSError on failure to align with existing FD_SETFD behavior.
This improves robustness in subprocess setup and error visibility.

Github-Pull: arun11299/cpp-subprocess#117
Rebased-From: 9974ff69cdd5fc1a2722cb63f006df9308628b35

Github-Pull: bitcoin#32358
Rebased-From: cd95c9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arun11299 arun11299 arun11299 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasandroil @arun11299
0