Add test for compare method standard error sorting consistency #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ReadTheDocs build appears to be failing due to a documentation system error related to type hints ( Any assistance that could be provided would be greatly appreciated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
Coverage 86.81% 86.82%
=======================================
Files 124 124
Lines 12972 12972
=======================================
+ Hits 11262 11263 +1
+ Misses 1710 1709 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OriolAbril
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test to verify that standard errors maintain their proper association with models in the compare method's output, regardless of input order.
The problem of standard errors not properly maintaining their association with models when the input order changed as mentioned in #2350 was resolved in issue #2351 but #2350 was left open for a test to be added to check just that.
Checklist
📚 Documentation preview 📚: https://arviz--2407.org.readthedocs.build/en/2407/