8000 Added CouchDB integration. by ipinak · Pull Request #30 · ashcrow/flask-track-usage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added CouchDB integration. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2016
Merged

Added CouchDB integration. #30

merged 5 commits into from
Jul 19, 2016

Conversation

ipinak
Copy link
Contributor
@ipinak ipinak commented Jul 15, 2016

No description provided.

@ipinak ipinak closed this Jul 15, 2016
@ipinak ipinak reopened this Jul 15, 2016
@ashcrow ashcrow self-assigned this Jul 18, 2016
@ashcrow
Copy link
Owner
ashcrow commented Jul 18, 2016

Thank you @ipinak! I'll review this shortly.

ashcrow
ashcrow reviewed Jul 18, 2016
View reviewed changes
src/flask_track_usage/storage/couchdb.py
print e 8000


class UsageData(Document):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would be nice to have a docstring here ... but I won't block on merging over it.

@ashcrow
Copy link
Owner
ashcrow commented Jul 18, 2016

@ipinak Looks good overall, I just have a few questions/comments above. Thank you again for this patch!

@ipinak
Copy link
Contributor Author
ipinak commented Jul 18, 2016

Very valid comments, I will fix them.

@ipinak
removes specific versions of packages
b1e0004 
adds docstring for the document
@ashcrow
Copy link
Owner
ashcrow commented Jul 19, 2016

LGTM

@ashcrow ashcrow merged commit 8005509 into ashcrow:master Jul 19, 2016
@ipinak ipinak deleted the couch_db branch August 4, 2016 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ashcrow ashcrow

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipinak @ashcrow
0