chore(sequencer): add app-level mempool tests for transaction inclusion #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44a69ac to
ff1d098
Compare
Fraser999
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added app-level mempool tests to ensure that transactions are successfully removed from the mempool with an "included" status in regular execution.
Background
#2133 added support for
TransactionStatuses, namely creating a newRemovalReason::IncludedInBlock. Tests were added to ensure that transaction IDs which were passed to the mempool inApp::commitwere successfully marked as "included", but no tests were added at a higher level to ensure that transactions are successfully conveyed between the different app methods and then to mempool. This led to a silent failure when the PR was first drafted, and the tests were deemed best suited for a followup.These changes aim to address the three possible execution flows within the app to ensure executed transaction IDs are successfully passed to the mempool in
commitno matter when they were executed:prepare_proposal(execution here) ->process_proposal->finalize_block->commitprocess_proposal(execution here) ->finalize_block->commitfinalize_block(execution here) ->commitChanges/Testing
app/tests/mempool.Changelogs
No updates required.
Related Issues
closes #2146