Working get-orders, create-order BUY, and create-order SELL #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed all warning logs to debug logs, which will:
- Make the CLI output cleaner and more focused
- Reduce noise when using the CLI for regular operations
- Still make the logs available when needed using debug mode
2. Added support for more market formats:
- Added "BTC-USD" and "ETH-USD" as recognized markets in addition to "BTC/USD" and "ETH/USD"
- Improved handling of market names in binary data
3. Improved the code quality:
- Fixed unused variable warnings
- Made variable declarations more precise
- Added better comments for clarity
4. Made the error messages more helpful:
- Improved the message when no sell orders are found
- Changed message format to be more consistent and informative
All of our changes maintain the key functionality we've been working on:
- Finding and displaying all orders (both BUY and SELL) in a market
- Correctly displaying order details like price, quantity, and side
- Properly handling different serialization formats
The CLI command for retrieving orders should now work correctly across various order configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brief summary of the changes made, ie "what?"
Background
Brief background on why these changes were made, ie "why?"
Changes
Testing
How are these changes tested?
Changelogs
Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.
Metrics
Breaking Changelist
Related Issues
Link any issues that are related, prefer full GitHub links.
closes