8000 Remove transform property from after psuedo element in copyright icon by denno020 · Pull Request #1 · astrit/css.gg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove transform property from after psuedo element in copyright icon #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

Remove transform property from after psuedo element in copyright icon #1

merged 1 commit into from
Dec 18, 2019

Conversation

denno020
Copy link
Contributor
@denno020 denno020 commented Dec 18, 2019 •
edited
Loading

As there is scale being applied to both the <i> and the pseudo element, it means that the scale applied to the psuedo element is being multiplied, so the C breaks out of the surrounding circle

Below is a screenshot taken from the https://css.gg/copyright page:

image

As we can see, the C has well and truly broken out of it's surrounding boundary.

By simply applying transform: none to the after psuedo element specifically, the result is:

image

@denno020
Remove transform property from after psuedo element in copyright icon
6d177d9 
As there is scale being applied to both the <i> *and* the pseudo element, it means that the scale applied to the psuedo element is being multiplied, so the C breaks out of the surrounding circle
@astrit astrit merged commit 027b180 into astrit:master Dec 18, 2019
@astrit
Copy link
Owner
astrit commented Dec 18, 2019

@denno020 thank you very much , I did not notice this after I combined.

@denno020
Copy link
Contributor Author

@astrit No worries at all! Glad I could help :)

@astrit
Copy link
Owner
astrit commented Dec 18, 2019

@denno020
https://github.com/astrit/css.gg/releases/tag/1.0.2

astrit added a commit that referenced this pull request Dec 26, 2019
@astrit
Fix: #7 - c:@spekulatius, #4 - i:@peiris c:@hunzaboy, #1 - c:@denno020 …
eee1baf 
…- v.1.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denno020 @astrit
0