txscript: add more detail to invalid tapscript merkle proof error #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appear
8000
s below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we add more detail to the invalid tapscript merkle proof error. Before this commit, the error was blank, making such a case hard to debug. We'll now log the expected witness program, what we derived, and also the passed in tapscript root.
Pull Request Test Coverage Report for Build 12143498639Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR improves debugging for invalid tapscript merkle proofs by adding detailed error messages.
- Updates test cases to verify specific error codes based on manipulated data.
- Enhances the error message in VerifyTaprootLeafCommitment to include the derived witness program, expected witness program, and tapscript root.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| txscript/taproot_test.go | Updated test cases to include expected error codes and modify mutation logic on proofs. |
| txscript/taproot.go | Enhanced error reporting with a detailed formatted string showing witness program details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add more detail to the invalid tapscript merkle proof error. Before this commit, the error was blank, making such a case hard to debug. We'll now log the expected witness program, what we derived, and also the passed in tapscript root.