8000 btcjson: add stubs for SubmitPackage by bhandras · Pull Request #2366 · btcsuite/btcd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

btcjson: add stubs for SubmitPackage #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

btcjson: add stubs for SubmitPackage #2366

wants to merge 1 commit into from
+246 −0

Conversation

bhandras
Copy link
Contributor
@bhandras bhandras commented May 5, 2025

Change Description

Bitcoin Core v26 introduced submitpackage, an atomic parent+child relay used by anchor-based fee schemes (P2A, TRUC/v3). Downstream projects such as btcwallet and LND need typed helpers so they can build requests without resorting to RawRequest. This PR adds the these stubs.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@coveralls
Copy link
coveralls commented May 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14889250035

Details

  • 0 of 73 (0.0%) changed or added relevant lines in 1 file are covered.
  • 88 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 56.488%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/submitpackage.go 0 73 0.0%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 80.95%
mempool/mempool.go 1 66.56%
txscript/taproot.go 2 95.98%
rpcclient/infrastructure.go 84 39.79%
Totals Coverage Status
Change from base Build 14871723979: -0.2%
Covered Lines: 31044
Relevant Lines: 54957
💛 - Coveralls

@bhandras bhandras force-pushed the submitpackage branch 2 times, most recently from 4b4b350 to 88de599 Compare May 5, 2025 19:23
@bhandras bhandras mentioned this pull request May 5, 2025
Open
7 tasks
@bhandras bhandras marked this pull request as ready for review May 5, 2025 20:04
@saubyk saubyk requested a review from kcalvinalvin May 6, 2025 00:02
@saubyk saubyk added this to the v0.25 milestone May 6, 2025
@saubyk saubyk added the TRUC label May 6, 2025
@bhandras bhandras mentioned this pull request May 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcalvinalvin kcalvinalvin Awaiting requested review from kcalvinalvin

At least 2 approving reviews are required to merge this pull request.

Assignees

@bhandras bhandras

Labels
TRUC
Projects
None yet
Milestone
v0.25
Development

Successfully merging this pull request may close these issues.
3 participants
@bhandras @coveralls @saubyk
0