23396 delegate validation 10.0 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30e8be6 to
770fb76
Compare
d319835 to
8cfb3ee
Compare
btry
pushed a commit
that referenced
this pull request
Sep 18, 2022
* Add PHPStan level 0 check
* Fix: Method NotificationSettingConfig::update() should return bool but return statement is missing.
* Fix: Method Html::showDatesTimelineGraph() should return array but return statement is missing.
* Fix: Array has 2 duplicate keys with value 'multiple' ('multiple', 'multiple').
* Fix: Access to an undefined property HTMLTableMain::$title.
* Fix: Access to an undefined property HTMLTableGroup::$ordered_headers.
* Fix: Variable $subheader_name is undefined
* Fix: Access to an undefined property HTMLTableCell::$numberOfLines.
* Fix: Access to an undefined property HTMLTableCell::$start.
* Fix: Call to function unset() contains undefined variable $name|$type|$cbbox|$cidinfo|$cw|$dw.
* Fix: Method GLPIMailer::setLanguage() should return bool but return statement is missing.
* Fix FieldUnicity display when there is no fields selected
* Fix: Method Glpi\Features\PlanningEvent::getAlreadyPlannedInformation() should return string but return statement is missing.
* Fix: Call to an undefined static method PlanningExternalEventTemplate::getVisibilityCriteria().
* Fix: Instantiated class CommonITILTask is abstract.
* Fix: Undefined variable: $options
* Fix: Method DropdownTranslation::regenerateAllCompletenameTranslationsFor() should return string but return statement is missing.
* Fix: Method Dropdown::showFrequency() should return int|string but return statement is missing.
* Fix: Method Domain_Item::showForItem() should return bool but return statement is missing.
* Remove Domain::getAdditionalFields() (Domain does not inherits CommonDropdown anymore)
* Fix: Method Document_Item::showAddFormForItem() should return bool but return statement is missing.
* Fix: Method Device*::getHTMLTableHeader() should return HTMLTableHeader but return statement is missing.
* Fix: Undefined variable: $RELATION
* Fix: Method DatabaseInstance::getTabNameForItem() should return string but return statement is missing.
* Fix: Method DCRoom::getTabNameForItem() should return string but return statement is missing.
* Fix: Result of method DBmysqlIterator::handleFields() (void) is used.
* Fix: Method DBmysql::rollBack() should return bool but return statement is missing.
* Fix: Method CronTask::cronInfo() should return array but return statement is missing.
* Fix rights checks on CronTask massive actions
* Fix: Result of method CronTask::showHistoryDetail() (void) is used.
* Fix: Method Contact::getAddress() should return string but return statement is missing.
* Fix: Method Consumable::getStatus() should return string but return statement is missing.
* Fix: Access to undefined constant Glpi\Console\Migration\UnsignedKeysCommand::ERROR_UNABLE_TO_UPDATE_CONFIG.
* Fix: Class DB not found.
* Fix: Undefined variable: $parent
* Fix: Undefined variable: $title
* Fix: Method CommonGLPI::canUpdate() should return bool but return statement is missing.
* Fix: Call to an undefined static method static(CommonGLPI)::getIcon().
* Fix: Call to an undefined method $this(CommonGLPI)::isField().
* Fix: Call to an undefined method CommonGLPI::getNameID().
* Fix: Call to an undefined method CommonGLPI::getFromDB().
* Fix: Access to an undefined property CommonGLPI::$fields.
* Fix: Call to an undefined method CommonGLPI::getLink().
* Fix: Method CommonGLPI::getErrorMessage() should return string but return statement is missing.
* Fix: Access to an undefined property CommonGLPI::$fields.
* Fix: Access to an undefined property CommonDBVisible::$entities|groups|profiles|users.
* Fix Glpi\Features\PlanningEvent::post_getEmpty()
* Fix: Parameter #1 $position (int) of method DBmysqlIterator::seek() is not contravariant with parameter #1 $offset (mixed) of method SeekableIterator::seek().
* Fix: Call to an undefined static method static(CommonDBTM)::getDcBreadcrumbSpecificValueToDisplay().
* Fix: Access to an undefined property CommonDBTM::$itemtype.
* Fix: Result of method CommonDBTM::canGlobal() (void) is used.
* Fix: Result of method CommonDBTM::updateInDB() (void) is used.
* Fix: Call to an undefined method CommonDBTM::clone().
* Fix: Method CommonDBTM::restoreSavedValues() should return array but return statement is missing.
* Fix: Method Certificate_Item::showForItem() should return bool but return statement is missing.
* Fix: Result of static method Contract::showCentral() (void) is used.
* Fix: Method Cartridge::uninstall() should return bool but return statement is missing.
* Fix: Method AuthLDAP::ldapImportUserByServerId() should return array|bool but return statement is missing.
* Fix: Unsafe usage of new static().
* Fix: Function brotli_compress|brotli_uncompress not found.
770fb76 to
81cf462
Compare
c441a1c to
c2ca53e
Compare
* Move actiontime and time_to_resolve to ITILTemplate fields as they are common for all ITIL Objects * fix tests Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
a50ff40 to
9b304d6
Compare
* Fix uploaded files names * Apply code suggestion Co-authored-by: Cédric Anne <cedric.anne@gmail.com> Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
The user can request a validation to his supervisor
0bbb17b to
a3c7d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of glpi-project#12504 for unit tests of Formcreator
Please update this template with something that matches your PR