Improve Full Packet parsing for HTTP #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 1, 2021
proto/proto.go
Outdated
| @@ -463,6 +464,30 @@ type HTTPState struct { | |||
| Continue100 bool | |||
| } | |||
|
|
|||
| var ValidHttpStart = [][]byte{ | |||
There was a problem hiding this comment.
exported var ValidHttpStart should have comment or be unexported
var ValidHttpStart should be ValidHTTPStart
houndci-bot
reviewed
Dec 1, 2021
proto/proto.go
Outdated
| @@ -463,6 +464,30 @@ type HTTPState struct { | |||
| Continue100 bool | |||
| } | |||
|
|
|||
| var ValidHttpStart = [][]byte{ | |||
There was a problem hiding this comment.
exported var ValidHttpStart should have comment or be unexported
var ValidHttpStart should be ValidHTTPStart
|
JB Feldman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
SonarCloud Quality Gate failed.
|
|
It still says that I havent signed the license, but I have |
|
Thank you, looks good! |
buger
pushed a commit
that referenced
this pull request
Jan 7, 2022
This PR does two primary things: - ensures that HasFullPayload returns false if the packet doesnt start with a valid request or response header. This was necessary because a chunked response would return true from HasFullPayload if it got contiguous packets including the last packet (with the trailer) before it got the first packet (with the header). - When the request payload is chunked across multiple packets, only correct for 100-Continue responses once. In requests with > 2 packets, the Ack number is incremented for each packet in the message, sometimes resulting in packets not being correlated with each other. This ensures that the message is corrected once and only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two primary things: