8000 fix: resolve pointer on tagged field by bxcodec · Pull Request #47 · bxcodec/faker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

fix: resolve pointer on tagged field #47

Merged
merged 5 commits into from
Jan 22, 2019
Merged

fix: resolve pointer on tagged field #47

merged 5 commits into from
Jan 22, 2019

Conversation

bxcodec
Copy link
Owner
@bxcodec bxcodec commented Jan 22, 2019

close #46

@codecov
Copy link
codecov bot commented Jan 22, 2019

Codecov Report

Merging #47 into master will decrease coverage by 1.4%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   96.03%   94.62%   -1.41%     
==========================================
  Files          10       10              
  Lines         529      540      +11     
==========================================
+ Hits          508      511       +3     
- Misses         11       15       +4     
-
8000
 Partials       10       14       +4
Impacted Files Coverage Δ
address.go 100% <ø> (ø) ⬆️
datetime.go 96.66% <ø> (-3.34%) ⬇️
faker.go 87.5% <77.77%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad75524...6159309. Read the comment docs.

@bxcodec bxcodec merged commit bfe096f into master Jan 22, 2019
@bxcodec bxcodec deleted the fixPointers branch January 22, 2019 06:58
@zveinn
Copy link
zveinn commented Jan 22, 2019

I can confirm that this is working properly, thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select the fake type when using pointers
2 participants
0