8000 NtpClock setup with Wi-Fi already initialized by denis-stepanov · Pull Request #25 · bxparks/AceTime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NtpClock setup with Wi-Fi already initialized #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2019
Merged

NtpClock setup with Wi-Fi already initialized #25

merged 4 commits into from
Sep 13, 2019

Conversation

denis-stepanov
Copy link
Contributor

Contribution to address issue #24. Also provided is an example showing use of setup() without parameters.

bxparks
bxparks approved these changes Sep 13, 2019
View reviewed changes
Copy link
Owner
@bxparks bxparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for the PR, it looks great! There were a handful of small nits, but they are so small, I think I will just merge, then fix them up later myself.

@bxparks bxparks merged commit d75d9c9 into bxparks:develop Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxparks bxparks bxparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-stepanov @bxparks
0