8000 fix: multiplayer desync caused by non-final local variables (see #245) by winex · Pull Request #289 · bahrmichael/factorio-tycoon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

fix: multiplayer desync caused by non-final local variables (see #245) #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: multiplayer desync caused by non-final local variables (see #245) #289

merged 1 commit into from
Mar 20, 2024

Conversation

winex
Copy link
Contributor
@winex winex commented Mar 19, 2024 •
edited
Loading

see #245 for information. 2 clients on dedicated server, same map:

  • TEST: for 1 hour while the city is growing [1100 citizens]
  • TEST: 9 hours has passed in semi-idle mode while the city was growing [2736 citizens]

i got no desyncs for 9 hours, looks like this fixes the biggest issue.

@winex
fix: multiplayer desync caused by non-final local variables (see bahr…
f4277da 
…michael#245)

1. remove non-final local variables.
2. simplify multiple functions into 1 table and 1 function
3. use city.generator() to randomize building names instead of iterating
@winex winex mentioned this pull request Mar 19, 2024
Merged
3 tasks
@winex winex marked this pull request as ready for review March 19, 2024 12:08
@bahrmichael bahrmichael merged commit fe35894 into bahrmichael:main Mar 20, 2024
@bahrmichael
Copy link
Owner

Thank you :)

@winex winex deleted the fix-desync-2 branch March 20, 2024 23:18
@winex winex mentioned this pull request Mar 27, 2024
Open
@winex winex mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahrmichael bahrmichael bahrmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winex @bahrmichael
0