http: fix read_file on win32 (wrong filesize) and use mbuf #711

fAuernigg · 2023-02-27T14:08:22Z

No description provided.

alfredh · 2023-02-28T11:04:26Z

reading a file into a buffer (mbuf or byte buffer) is quite generic

perhaps it is better to place the function in the SYS module ?

fAuernigg · 2023-03-01T09:15:24Z

reading a file into a buffer (mbuf or byte buffer) is quite generic

perhaps it is better to place the function in the SYS module ?

Is current approach ok now in sys module?

src/sys/fs.c

This was referenced Feb 27, 2023

Add tls and http apis for post handshake #713

Merged

Client cert renegotiation in http #687

Closed

cspiel1 marked this pull request as ready for review February 27, 2023 14:49

fAuernigg force-pushed the fix_readfile_on_win32 branch 5 times, most recently from 324a07f to 14056e2 Compare February 28, 2023 12:10

sreimers reviewed Mar 1, 2023

View reviewed changes

src/sys/fs.c Outdated Show resolved Hide resolved

http, sys: mv read_file to fs_fread and fix win32 (wrong size) via mbuf

53f600f

fAuernigg force-pushed the fix_readfile_on_win32 branch from 14056e2 to 53f600f Compare March 1, 2023 10:29

sreimers merged commit 954d197 into baresip:main Mar 1, 2023

Provide feedback