8000 jbuf: constant jbuf_put() by cspiel1 · Pull Request #821 · baresip/re · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

jbuf: constant jbuf_put() #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2023
Merged

jbuf: constant jbuf_put() #821

merged 3 commits into from
Jun 1, 2023

Conversation

cspiel1
Copy link
Collaborator
@cspiel1 cspiel1 commented May 22, 2023

No description provided.

@cspiel1 cspiel1 mentioned this pull request May 22, 2023
Merged
sreimers
sreimers reviewed May 22, 2023
View reviewed changes
@cspiel1
Copy link
Collaborator Author
cspiel1 commented May 23, 2023

Now the tests are green. Without the last commit this test was negative: test_jbuf_adaptive_video(). It contains the "unordered late packet" situation you described above. Should I add more such tests?

@sreimers
Copy link
Member

Thanks, looks good to me now. We should add a test where late packet is a unique frame (should already work with your PR).

Sequence,Timestamp:

1, 1
2, 1
4, 3
3, 2 < This is delayed

@cspiel1
Copy link
Collaborator Author
cspiel1 commented May 23, 2023

I'll add such a test here in this PR. This fits good to the topic.

@cspiel1 cspiel1 marked this pull request as ready for review May 23, 2023 09:16
@cspiel1 cspiel1 force-pushed the jbuf_constant_insert branch from 7921789 to 4f44f42 Compare May 23, 2023 09:19
@cspiel1
Copy link
Collaborator Author
cspiel1 commented May 23, 2023

Changed commit message of main commit.

@cspiel1 cspiel1 mentioned this pull request May 23, 2023
Merged
@cspiel1
Copy link
Collaborator Author
cspiel1 commented May 23, 2023

@sreimers do you still think that nf counting is unreliable with this PR?

@sreimers
Copy link
Member

Looks good to me, but I will do some more tests...

@cspiel1 cspiel1 added this to the v3.3.0 milestone May 30, 2023
@sreimers sreimers merged commit 3b84d00 into baresip:main Jun 1, 2023
@cspiel1 cspiel1 deleted the jbuf_constant_insert branch June 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreimers sreimers sreimers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cspiel1 @sreimers
0