8000 Cut release before Ramadan by basememara · Pull Request #70 · batoulapps/adhan-swift · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cut release before Ramadan #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 14, 2022
Merged

Cut release before Ramadan #70

merged 21 commits into from
Mar 14, 2022

Conversation

basememara
Copy link
Contributor

Salaam, was thinking we should cut a release before the flood of Ramadan prayer times requests, feedback, and issues come rolling in. This way, hot fixes will be easier to apply from the tip of the latest code and also let the latest addition burn in and flush out. What do you think?

basememara and others added 21 commits June 3, 2021 08:45
Embed recommended high altitude rule into prayer calculations
Fix for running tests against shared JSON files in SPM
Improvement to how we get next and previous days in SolarTime
Fix test data subtree
Adds a new property to calculation parameters shafaq
that is used by the MoonsightingCommittee method to
calculate Isha.
feat(calculation params): adds shafaq parameter
@basememara
Copy link
Contributor Author

Btw, I've been using the "altitude rule based on coordinates" changes in production for almost a year now and has been working well.

@z3bi
Copy link
Contributor
z3bi commented Mar 14, 2022

Oh thanks for the reminder! This fell off my radar for a bit.

@z3bi
Copy link
Contributor
z3bi commented Mar 14, 2022

Btw, I've been using the "altitude rule based on coordinates" changes in production for almost a year now and has been working well.

Awesome!

@z3bi z3bi merged commit 6dc8309 into main Mar 14, 2022
@z3bi z3bi deleted the develop branch March 14, 2022 18:19
@z3bi z3bi restored the develop branch March 14, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0