Cut release before Ramadan #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `develop` branch
Embed recommended high altitude rule into prayer calculations
Fix for running tests against shared JSON files in SPM
Improvement to how we get next and previous days in SolarTime
Fix test data subtree
Adds a new property to calculation parameters shafaq that is used by the MoonsightingCommittee method to calculate Isha.
feat(calculation params): adds shafaq parameter
|
Btw, I've been using the "altitude rule based on coordinates" changes in production for almost a year now and has been working well. |
|
Oh thanks for the reminder! This fell off my radar for a bit. |
Awesome! |
z3bi
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salaam, was thinking we should cut a release before the flood of Ramadan prayer times requests, feedback, and issues come rolling in. This way, hot fixes will be easier to apply from the tip of the latest code and also let the latest addition burn in and flush out. What do you think?