WORLDSERVICE-486: Use viewability model for component tracking on TEST #12648
+953
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of github.com:bbc/simorgh into WORLDSERVICE-486-use-viewability-for-component-tracking
alex-magana
commented
Apr 29, 2025
Comment on lines
96
to
133
| // Component Views & Clicks - Viewability Model | ||
| Object.values(COMPONENTS).forEach(component => { | ||
| const viewEventRegex = new RegExp( | ||
| `\\[\\{"name":"viewability\\.view","data":\\{(?:.*)?"event":\\{"category":"viewability","action":"view"\\}(?:.*)?"item":\\{(?:.*)?"name":"${component}(.*)?"(?:.*)?\\}\\}\\}\\]`, | ||
| 'g', | ||
| ); | ||
|
|
||
| const clickEventRegex = new RegExp( | ||
| `\\[\\{"name":"viewability\\.select","data":\\{(?:.*)?"event":\\{"category":"viewability","action":"select"\\}(?:.*)?"item":\\{(?:.*)?"name":"${component}(.*)?"(?:.*)?\\}\\}\\}\\]`, | ||
| 'g', | ||
| ); | ||
|
|
||
| // Component Views | ||
| cy.intercept( | ||
| { | ||
| url: `${atiUrl}/*`, | ||
| query: { | ||
| events: viewEventRegex, | ||
| }, | ||
| }, | ||
| request => { | ||
| request.reply({ statusCode: 200 }); | ||
| }, | ||
| ).as(`${component}-ati-view-viewability`); | ||
|
|
||
| // Component Clicks | ||
| cy.intercept( | ||
| { | ||
| url: `${atiUrl}/*`, | ||
| query: { | ||
| events: clickEventRegex, | ||
| }, | ||
| }, | ||
| request => { | ||
| request.reply({ statusCode: 200 }); | ||
| }, | ||
| ).as(`${component}-ati-click-viewability`); | ||
| }); |
There was a problem hiding this comment.
I've duplicated the CPV model logic instead of abstracting the matchers
into a function to retain the verbose nature of the tests.
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
…' of github.com:bbc/simorgh into WORLDSERVICE-486-use-viewability-for-component-tracking
|
Thanks for the feedback @karinathomasbbc |
karinathomasbbc
approved these changes
Apr 30, 2025
amoore108
approved these changes
Apr 30, 2025
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-486
Summary
Adopt the viewability model for reporting click and view component events.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links