8000 Polish navigation: add Poland and Ukraine war by jordit · Pull Request #12699 · bbc/simorgh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Polish navigation: add Poland and Ukraine war #12699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

Polish navigation: add Poland and Ukraine war #12699

merged 2 commits into from
May 1, 2025
+9 −2

Conversation

jordit
Copy link
Contributor
@jordit jordit commented Apr 30, 2025

Resolves JIRA n/a

Overall changes

  • Adds a couple of items to the Polish navigation bar

Code changes

  • Edited Navigation section of src/app/lib/config/services/polska.ts to add the Poland and War in Ukraine topic links

image

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@Isabella-Mitchell
Copy link
Contributor

Heya - I'm making a quick change - then will merge this is

Isabella-Mitchell
Isabella-Mitchell approved these changes May 1, 2025
View reviewed changes
src/app/lib/config/services/polska.ts Outdated
title: 'News',
url: '/polska',
hideOnLiteSite: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set 'hideOnLiteSite' to false for these links? Or can we just not include it. It's set to optional in src/app/models/types/serviceConfig.ts

8000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, according to the code default is false, so is really only required if a link needs to be hidden on .lite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove 😸

@jordit jordit merged commit 32043f6 into latest May 1, 2025
11 checks passed
@jordit jordit deleted the pl-nav branch May 1, 2025 08:57
@jordit
Copy link
Contributor Author
jordit commented May 1, 2025

thanks @amoore108 , @karinathomasbbc and @Isabella-Mitchell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@amoore108 amoore108 amoore108 approved these changes

@Isabella-Mitchell Isabella-Mitchell Isabella-Mitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordit @Isabella-Mitchell @amoore108 @karinathomasbbc
0