8000 WORLDSERVICE-682: RTL Mobile Space Fix by HarveyPeachey · Pull Request #12703 · bbc/simorgh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WORLDSERVICE-682: RTL Mobile Space Fix #12703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

WORLDSERVICE-682: RTL Mobile Space Fix #12703

merged 2 commits into from
May 6, 2025
+40 −50

Conversation

HarveyPeachey
Copy link
Contributor
@HarveyPeachey HarveyPeachey commented May 2, 2025 •
edited
Loading

Resolves JIRA: WORLDSERVICE-682

Summary

Swaps out explicit top, bottom, left, right with inset blocks and inlines for reading direction agnostics for the navigation divider.

Code changes

  • Swaps individual insets for inset-block and inset-inline in the navigation divider.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@HarveyPeachey HarveyPeachey self-assigned this May 2, 2025
karinathomasbbc
karinathomasbbc approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor
@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting one of the snapshots to have changed - is it too late to add a story for this now? Or is that overkill?

@HarveyPeachey
Copy link
Contributor Author

I was expecting one of the snapshots to have changed - is it too late to add a story for this now? Or is that overkill?

A snapshot wouldn't quite catch this issue, as it requires scrolling right after the page loads to see the bug

hotinglok
hotinglok approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator
@hotinglok hotinglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarveyPeachey HarveyPeachey merged commit 3c651f6 into latest May 6, 2025
11 checks passed
@HarveyPeachey HarveyPeachey deleted the WORLDSERVICE-682-rtl-mobile-site-space-fix branch May 6, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotinglok hotinglok hotinglok approved these changes

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

Assignees

@HarveyPeachey HarveyPeachey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarveyPeachey @hotinglok @karinathomasbbc
0