8000 WORLDSERVICE-800: Adds OnDemandAudio snapshots by Isabella-Mitchell · Pull Request #12704 · bbc/simorgh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WORLDSERVICE-800: Adds OnDemandAudio snapshots #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: latest
Choose a base branch
from
Open

WORLDSERVICE-800: Adds OnDemandAudio snapshots #12704

wants to merge 4 commits into from
+95 −6

Conversation

Isabella-Mitchell
Copy link
Contributor
@Isabella-Mitchell Isabella-Mitchell commented May 2, 2025 •
edited
Loading

Resolves JIRA: https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-800

Summary

Adds snapshots for the On Demand Audio / Podcast Page (Canonical and Lite at a selection of Desktop / Mobile breakpoints)

Code changes

  • Adds snapshot tests to OnDemandAudio stories
  • Renames OnDemandRadio to OnDemandAudio to reflect podcast & radio pages
  • Apply optional chaining to ExternalLinks check

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

Review snapshots (UI tests) added: https://bbc.chromatic.com/build?appId=5d28eb3fe163f6002046d6fa&number=56958

(Note, the player is missing - even on our latest version - I think it does not load in on time)

Useful Links

@Isabella-Mitchell Isabella-Mitchell changed the title Adds Lite snapshots WORLDSERVICE-800: OnDemandAudio snapshots May 2, 2025
@Isabella-Mitchell Isabella-Mitchell changed the title WORLDSERVICE-800: OnDemandAudio snapshots WORLDSERVICE-800: Adds OnDemandAudio snapshots May 2, 2025
@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review May 2, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayneahchoon shayneahchoon shayneahchoon approved these changes

@emilysaffron emilysaffron emilysaffron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isabella-Mitchell @shayneahchoon @emilysaffron
0