8000 NOTICKET - Support other media types in `legacyMedia` by amoore108 · Pull Request #12712 · bbc/simorgh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOTICKET - Support other media types in legacyMedia #12712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

NOTICKET - Support other media types in legacyMedia #12712

wants to merge 2 commits into from
+13 −4

Conversation

amoore108
Copy link
Contributor
@amoore108 amoore108 commented May 6, 2025 •
edited
Loading

Summary

  • Removes restriction on allowing only mp4 media for legacyMedia content
  • The SMP player will chose the working version of the playlist of items should there include some that 404

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. Visit http://localhost.bbc.com:7080/arabic/multimedia/2013/12/131208_iraq_blast?renderer_env=live
  2. Confirm media plays back
  3. Visit http://localhost.bbc.com:7080/gahuza/umviriza_kandi/2014/07/140714_imvo?renderer_env=live
  4. Confirm media plays back. This is an audio file, so no placeholder image will show
8000

Useful Links

@amoore108 amoore108 self-assigned this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@amoore108 amoore108

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amoore108 @karinathomasbbc
0