8000 WORLDSERVICE-306: Implement No JS message for media loaders without placeholders by karinathomasbbc · Pull Request #12270 · bbc/simorgh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WORLDSERVICE-306: Implement No JS message for media loaders without placeholders #12270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 9, 2025
Merged

WORLDSERVICE-306: Implement No JS message for media loaders without placeholders #12270

merged 17 commits into from
May 9, 2025

Conversation

karinathomasbbc
Copy link
Contributor
@karinathomasbbc karinathomasbbc commented Jan 13, 2025 •
edited
Loading

Resolves JIRA https://jira.dev.bbc.co.uk/browse//WORLDSERVICE-306

Overall changes

Displays a translated message instead of the media player (along the lines of: "To play this content, please enable JavaScript, or try a different browser") if Javascript is disabled

Code changes

  • Add a noscript block to the media container, so that the No JS message can be rendered as expected

Testing

Disable JS and navigate to http://localhost:7080/hausa/bbc_hausa_radio/liveradio
The No JS message should be displayed as expected

Screenshot 2025-01-13 at 14 54 04

@karinathomasbbc karinathomasbbc self-assigned this Jan 13, 2025
@karinathomasbbc karinathomasbbc changed the title Implement No JS message for media loaders without placeholders WSTEAM1-1581: Implement No JS message for media loaders without placeholders Jan 13, 2025
@karinathomasbbc karinathomasbbc changed the title WSTEAM1-1581: Implement No JS message for media loaders without placeholders WORLDSERVICE-306: Implement No JS message for media loaders without placeholders May 1, 2025
@karinathomasbbc karinathomasbbc marked this pull request as ready for review May 1, 2025 16:01
hotinglok
hotinglok reviewed May 2, 2025
View reviewed changes
@karinathomasbbc karinathomasbbc merged commit d84723d into latest May 9, 2025
11 checks passed
@karinathomasbbc karinathomasbbc deleted the no-js-media-loader branch May 9, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenc05 greenc05 greenc05 approved these changes

@hotinglok hotinglok hotinglok approved these changes

@Isabella-Mitchell Isabella-Mitchell Isabella-Mitchell approved these changes

Assignees

@karinathomasbbc karinathomasbbc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karinathomasbbc @greenc05 @hotinglok @Isabella-Mitchell
0