10000 26975 - Outputs and email templates for Appoint and Cease Receiver / Receiver Manager filing by ketaki-deodhar · Pull Request #3503 · bcgov/lear · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

26975 - Outputs and email templates for Appoint and Cease Receiver / Receiver Manager filing #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 2, 2025
Merged

26975 - Outputs and email templates for Appoint and Cease Receiver / Receiver Manager filing #3503

merged 26 commits into from
Jun 2, 2025
+901 −201

Conversation

ketaki-deodhar
Copy link
Collaborator
@ketaki-deodhar ketaki-deodhar commented May 22, 2025 •
edited
Loading

Issue #: /bcgov/entity#26975

Description of changes:

Appoint Receiver output:
image

Cease Receiver output:
image

image

Business summary:
image

Emails:
image

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@ketaki-deodhar ketaki-deodhar self-assigned this May 22, 2025
@codecov Codecov
Copy link
codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 84 lines in your changes missing coverage. Please review.

Project coverage is 75.12%. Comparing base (57e1e19) to head (b97288b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../email_processors/appoint_receiver_notification.py 23.52% 39 Missing ⚠️
legal-api/src/legal_api/reports/report.py 6.89% 27 Missing ⚠️
...gal-api/src/legal_api/reports/business_document.py 36.36% 6 Missing and 1 partial ⚠️
legal-api/src/legal_api/config.py 96.63% 2 Missing and 2 partials ⚠️
...rvices/entity-emailer/src/entity_emailer/worker.py 0.00% 2 Missing and 1 partial ⚠️
...api/services/filings/validations/cease_receiver.py 0.00% 2 Missing ⚠️
...er/email_processors/cease_receiver_notification.py 0.00% 1 Missing ⚠️
...c/entity_filer/filing_processors/cease_receiver.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   76.09%   75.12%   -0.98%     
==========================================
  Files         204      290      +86     
  Lines       13665    18094    +4429     
  Branches     2332     3046     +714     
==========================================
+ Hits        10399    13593    +3194     
- Misses       2602     3561     +959     
- Partials      664      940     +276
Flag Coverage Δ
entityemailer 65.88% <23.21%> (?)
entityfiler 79.37% <85.71%> (?)
legalapi 75.89% <75.15%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
legal-api/src/legal_api/services/authz.py 96.39% <ø> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py 83.78% <100.00%> (ø)
...er/email_processors/cease_receiver_notification.py 23.52% <0.00%> (ø)
...c/entity_filer/filing_processors/cease_receiver.py 76.47% <85.71%> (ø)
...api/services/filings/validations/cease_receiver.py 34.78% <0.00%> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 59.32% <0.00%> (ø)
legal-api/src/legal_api/config.py 95.20% <96.63%> (ø)
...gal-api/src/legal_api/reports/business_document.py 44.41% <36.36%> (-0.21%) ⬇️
legal-api/src/legal_api/reports/report.py 22.89% <6.89%> (-1.05%) ⬇️
.../email_processors/appoint_receiver_notification.py 23.52% <23.52%> (ø)

... and 81 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ketaki-deodhar
ketaki-deodhar commented May 22, 2025
View reviewed changes
legal-api/src/legal_api/services/authz.py
@@ -1007,6 +1007,7 @@ def has_product(code: str, token: str) -> bool:

return any(p['code'] == code and p['subscriptionStatus'] == 'ACTIVE' for p in user_products)


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed lint issue only

ketaki-deodhar
ketaki-deodhar commented May 22, 2025
View reviewed changes
legal-api/src/legal_api/config.py
'development': 'legal_api.config.DevConfig',
'testing': 'legal_api.config.TestConfig',
'production': 'legal_api.config.ProdConfig',
'default': 'legal_api.config.ProdConfig',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed lint issues only

@ketaki-deodhar ketaki-deodhar marked this pull request as ready for review May 22, 2025 19:20
ArwenQin
ArwenQin approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator
@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The outputs look good to me.

vysakh-menon-aot
vysakh-menon-aot reviewed May 23, 2025
View reviewed changes
Copy link
Collaborator
@vysakh-menon-aot vysakh-menon-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replicate this change in business-filer and business-emailer

@vysakh-menon-aot
Copy link
Collaborator

Can you look into the linting and testing issues

@vysakh-menon-aot vysakh-menon-aot merged commit 2e6cc2c into bcgov:main Jun 2, 2025
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meawong meawong meawong left review comments

@vysakh-menon-aot vysakh-menon-aot vysakh-menon-aot approved these changes

@ArwenQin ArwenQin ArwenQin approved these changes

Assignees

@ketaki-deodhar ketaki-deodhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ketaki-deodhar @vysakh-menon-aot @ArwenQin @meawong
0