-
Notifications
You must be signed in to change notification settings - Fork 8
feat: multichain sessions #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joepegler
wants to merge
22
commits into
develop
Choose a base branch
from
feat/multichain_smar_sessions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+856
−417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba7fc64
to
ba0a494
Compare
ba0a494
to
2c14d78
Compare
size-limit report 📦
|
b03e1c9
to
3a59d28
Compare
3a59d28
to
9ddeee3
Compare
0a57dbf
to
8e6eb22
Compare
6ad1cc6
to
460f3c6
Compare
aca67b5
to
e0bc2cb
Compare
ce19694
to
d271f1f
Compare
46c76b2
to
4511490
Compare
4511490
to
95b52bc
Compare
ecb4691
to
c712936
Compare
* fix: session validator initdata * chore: gas limit * chore: add short encoding flag to getQuote * fix: passing the validator module to prepareUserOps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on enhancing the functionality of the
multichainRead
feature and related components in the SDK, introducing new methods, expanding existing functionalities, and improving error handling.Detailed summary
multichainRead
insrc/sdk/account/decorators/index.ts
.stringifyToNumber
function insrc/sdk/modules/validators/smartSessions/Helpers.ts
.getNonceWithKey
to accept additional parameters insrc/sdk/account/toNexusAccount.ts
.grantPermission
to utilizegetSudoPolicy
insrc/sdk/modules/validators/smartSessions/decorators/grantPermission.ts
.multichainRead
function insrc/sdk/account/toMultiChainNexusAccount.ts
.multichainRead
insrc/sdk/account/decorators/multichainRead.test.ts
.src/sdk/account/utils/parseErrorMessage.ts
.getQuote
to includemoduleAddress
andshortEncodingSuperTxn
parameters insrc/sdk/clients/decorators/mee/getQuote.ts
.meeSessionActions
insrc/sdk/modules/validators/smartSessions/decorators/mee/index.ts
to include new permissions.src/sdk/modules/validators/smartSessions/toMultichainSmartSessions.test.ts
.