10000 feature_03_to_testing by MadhuTangudu · Pull Request #13 · bdiptesh/CodeLib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feature_03_to_testing #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 27, 2021
Merged

feature_03_to_testing #13

merged 13 commits into from
Sep 27, 2021

Conversation

MadhuTangudu
Copy link
Collaborator

Description

kNN module for both classification and regression

Tickets

Type of change

Please select option(s) that are relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit/Integration tests in the code
  • Code runs locally without any warnings/errors with test files

Checklist:

  • New and existing unit tests pass locally with my changes
  • I have added tests including corner cases that prove my fix is effective or that my feature works
  • I have run tests before committing
  • My code follows the contribution guidelines of this project
  • I have performed a self & peer review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings/errors
  • Any dependent changes have been merged and published in downstream modules
  • Left side is NOT stable branch. Example: Left side is testing branch
  • Right side is YOUR branch. Example: feature_36

MadhuTangudu and others added 13 commits September 25, 2021 20:55
changelog:
- added knn.py and test_knn.py modules
- added iris.csv dataset
changelog:
- added parallel processing by default in KNN module
changelog:
- _compute_metrics method added
changelog:
- minor changes in variables names
changelog:
- cross validation metric changed to accuracy and rmse for classification and regresion in knn.py file
- test for categorical variable added to test_knn.py
changelog:
-added ignore warnings decorator in unit tests
changelog:
- code cleaning of knn.py, test_knn.py, model.py and test_model.py
changelog:
- knn classification's default scorer changed to f1_weighted
- removed some redundant codes
changelog:
- local run test
@MadhuTangudu MadhuTangudu added the merge Merge label Sep 27, 2021
@MadhuTangudu MadhuTangudu added this to the v0.4.0 milestone Sep 27, 2021
@bdiptesh bdiptesh added the stats Statistics label Sep 27, 2021
@bdiptesh bdiptesh merged commit 3380612 into testing Sep 27, 2021
@bdiptesh bdiptesh deleted the feature_03 branch September 27, 2021 09:40
@bdiptesh bdiptesh removed this from the v0.4.0 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Merge stats Statistics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kNN: Optimal k
2 participants
0