Add ObligatoryPrintDirectives #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
449c4ae to
987e3ec
Compare
mhupman
reviewed
Jan 4, 2018
soyhtml/exec.go
Outdated
| @@ -330,6 +330,33 @@ func (s *state) evalPrint(node *ast.PrintNode) { | |||
| } | |||
| } | |||
|
|
|||
| for _, directiveName := range ObligatoryPrintDirectiveNames { | |||
There was a problem hiding this comment.
Could you instead append this to the list of node directives on #302 to avoid duplicating the code?
There was a problem hiding this comment.
I can do that. It feels a little weird because I have to turn it into a Node which has a Position but the directive doesn't actually appear in the input anywhere. I'll just give it the same position as the PrintNode that it belongs to, I don't think it's too important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow callers to inject print directives that are applied by default.
Sometimes we accidentally print null variables, this would allow us to inject a directive that renders these as an empty string instead of as the word 'null'.