fix request.service_key strip suffix #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splittingred
reviewed
Feb 4, 2025
| @@ -87,7 +87,7 @@ def initialize(method_key:, service:, rpc_desc:, active_call:, message:) | |||
| # @return [String] The mapped service key | |||
| # | |||
| def service_key | |||
| @service.name.to_s.underscore.tr('/', '.').gsub('.service', '') | |||
| @service.name.to_s.underscore.tr('/', '.').delete_suffix('.service') | |||
There was a problem hiding this comment.
Hi @t0ch1k - can we add a unit test that covers your case explicitly? (that it deletes only the suffix, not all instances)
There was a problem hiding this comment.
Oh wow, sorry, I missed your message and only now saw it. Fixed :)
|
unfortunately rubocop fails on the code I didn't touch :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I don't want service_key to remove all the occurrences of
.service, only to strip suffixHow was it tested?
within the existing unit tests + manually