set rx rate to unlimited for knet #450
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4da7814 to
f10dc87
Compare
Update proto to latest HEAD: ofdpa.proto: expose ofdpaRxRateSet() Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
f10dc87 to
d557d57
Compare
Since KNET uses a different channel for packets than OpenFlow and is much more efficient, higher packet rates than 1024 (the default) is easily doable. So set the rx rate to unlimited by default when using KNET, but leave it at 1024 pps for TAP. In case this causes issues, add a flag to set a custom limit. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
d557d57 to
197e422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since KNET uses a different channel for packets than OpenFlow and is much more efficient, higher packet rates than 1024 (the default) is easily doable.
So set the rx rate to unlimited by default when using KNET, but leave it at 1024 pps for TAP.
In case this causes issue, add a flag to set a custom limit.
Description
Motivation and Context
How Has This Been Tested?