8000 Fixed order of params to start command in Keycloak run.sh by AntonAleksandrov13 · Pull Request #81853 · bitnami/containers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed order of params to start command in Keycloak run.sh #81853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed order of params to start command in Keycloak run.sh #81853

wants to merge 1 commit into from
+4 −4

Conversation

AntonAleksandrov13
Copy link
@AntonAleksandrov13 AntonAleksandrov13 commented Jun 2, 2025 •
edited by carrodher
Loading

Description of the change

I have moved adding start_params to start_command before adding extra arguments. This results in a valid command if KEYCLOAK_EXTRA_ARGS_PREPENDED is provided

Benefits

Keycloak can start if KEYCLOAK_EXTRA_ARGS_PREPENDED is provided

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

@github-actions github-actions bot added keycloak triage Triage is needed labels Jun 2, 2025
@github-actions github-actions bot requested a review from carrodher June 2, 2025 09:46
@AntonAleksandrov13 AntonAleksandrov13 mentioned this pull request Jun 2, 2025
Closed
@AntonAleksandrov13
adding params after the start command
92f82a0 
Signed-off-by: anton.aleksandrov <anton.aleksandrov@jetbrains.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 3, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jun 3, 2025
@github-actions github-actions bot removed the request for review from carrodher June 3, 2025 08:00
@github-actions github-actions bot requested a review from juan131 June 3, 2025 08:00
@juan131
Copy link
Contributor
juan131 commented Jun 4, 2025

Please correct me if I'm wrong but you already have KEYCLOAK_EXTRA_ARGS for your use case. I mean I'd expect KEYCLOAK_EXTRA_ARGS_PREPENDED arguments to be prepended instead of appended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 Awaiting requested review from juan131

At least 1 approving review is required to merge this pull request.

Assignees

@juan131 juan131

Labels
in-progress keycloak verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/keycloak] run.sh adds KEYCLOAK_EXTRA_ARGS_PREPENDED flags before the start command
3 participants
@AntonAleksandrov13 @juan131 @carrodher
0