Screensaver timeout #525
Screensaver timeout #525
Conversation
| @@ -61,6 +61,7 @@ export class SettingsComponent { | |||
| this.form = this.fb.group({ | |||
| flipscreen: [info.flipscreen == 1], | |||
| invertscreen: [info.invertscreen == 1], | |||
| screenTimeout: [info.screenTimeout, [Validators.required]], | |||
There was a problem hiding this comment.
I could be wrong, but I don't think it's needed here. There use to be more in settings, but think a lot got moved to the edit component and this may need to be cleaned up?
There was a problem hiding this comment.
I guess you're right. There is no difference without this line (tested with "ng serve").
Should it be removed? Html is trial and error for me
There was a problem hiding this 8000 comment.
Really this whole form (fb) should probably be removed as I don't think its needed in this file anymore. Shouldn't matter if you leave it or remove it, as the whole section should be cleaned up in a separate PR IMO
|
What about the config-*.cvs files? Do they contain default values for factory images? |
|
with moving over to LVGL shortly, can this be adapted? |
I'll look into it. We don't have a backlight with OLED, right?
|
|
Here is a branch with LVGL (untested) |
|
Take a look at https://docs.lvgl.io/9.2/overview/display.html#inactivity, there's already an inactivity timer built in, which resets automatically on any input, e.g. button press. I think it only needs to be checked in There's no backlight indeed. |
|
Ah thank you! Is it correct that we need our own timer to call lv_tick_inc? And we would be limited to uint32 with ~49 days of inactivity? |
No, ticks are handled by the framework. Each lv_tick, |
f3b42be to
c36b4ca
Compare
a1c543b to
76b2da5
Compare
main/http_server/axe-os/src/app/components/edit/edit.component.html
Outdated
Show resolved
Hide resolved
76b2da5 to
5d2f20a
Compare
5d2f20a to
1820153
Compare
|
I did some experimenting with a slider and custom values, but I didn't like the result, it's clunky.
Maybe simpler is easier in this case, just do a number input, where -1 is no screensaver (aka always on) and 0 is display off. |
1820153 to
405b436
Compare
|
I wonder if we can do without |
|
It looks like every driver sends every command to the queue without prior checking. Does the state in Yes, perhaps the name |
4ab7b1a to
7050538
Compare
|
@terratec please resolve conflicts |
7050538 to
77aef89
Compare
* Add config for display timeout * Display timeout logic * Move lv_display_trigger_activity into screen_show * Use a numeric input field for timeout config * Merge display on/off functions
* Add config for display timeout * Display timeout logic * Move lv_display_trigger_activity into screen_show * Use a numeric input field for timeout config * Merge display on/off functions
Resolves #515