8000 Update gitignore, simplify layout, fix refresh button UI, unify headlines/margins, improve modal responsiveness and theme color selection by ciruz · Pull Request #834 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update gitignore, simplify layout, fix refresh button UI, unify headlines/margins, improve modal responsiveness and theme color selection #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 22, 2025
Merged

Update gitignore, simplify layout, fix refresh button UI, unify headlines/margins, improve modal responsiveness and theme color selection #834

merged 12 commits into from
Apr 22, 2025

Conversation

ciruz
Copy link
Contributor
@ciruz ciruz commented Apr 10, 2025

  • chore: copied system files .gitignore entries from /axe-os/.gitignore to globally ignore system files (like .DS_Store, since my mac added those)

  • fix: reduced left padding on tablets

before on tablet:

image

after on tablet:

image

  • fix (home): cleaned up grid, removed a grid and some margins

before:

image

after:

image

  • style: refresh button width grid stacking.
    I noticed the refresh button's width changed based on the countdown seconds, I used grid stacking to preserve a consistent width.

before:

before

after:

after

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: I also unified the headlines to use consistent <h2> tags across all sections.

before:

image

image

image

image

after:

image

image

image

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: I also improved the theme selection, centered the color buttons, added an indicator for the active theme, and added a SCSS module for styling.

before:

image

after:

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: I adjusted the modal width to use dvw instead of vw for better mobile responsiveness. This ensures the modal fits within the visible viewport on smaller devices.

Before mobile:

image

After mobile:

image

Before tablet:

image

After tablet:

image

Before desktop:

image

After desktop:

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: fix icon alignment in swarm table.

before:

image

after:

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: Unified card margin to match surrounding layout

before:

image

after:

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: modified the settings card, to have same height.

before:

image

after:

image

@ciruz
Copy link
Contributor Author
ciruz commented Apr 11, 2025

Update: Fix card column layout on smaller desktops.

before:

image

after:

image

@ciruz ciruz changed the title update gitignore, layout simplifications, and refresh button UI fix Update gitignore, simplify layout, fix refresh button UI, unify headlines/margins, improve modal responsiveness and theme color selection Apr 11, 2025
@STSMiner1
Copy link
Contributor
STSMiner1 commented Apr 12, 2025 •
edited
Loading

Been testing this with the latest commits (d86bf28), browser (Chrome) window on the right showing the changes to the layout.

image

image

image

image

image

@WantClue WantClue added the design Design Enhancements label Apr 12, 2025
@WantClue WantClue added this to the 2.6.6 milestone Apr 16, 2025
@WantClue WantClue added the accepted This issue will be worked on label Apr 16, 2025
WantClue
WantClue approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator
@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@WantClue WantClue merged commit 610e91c into bitaxeorg:dev-latest Apr 22, 2025
2 checks passed
WantClue pushed a commit that referenced this pull request May 2, 2025
@ciruz @WantClue
Update gitignore, simplify layout, fix refresh button UI, unify headl…
c18a99a 
…ines/margins, improve modal responsiveness and theme color selection (#834)

* chore: ignore .DS_Store and system files in .gitignore

* fix(layout): reduce left padding on tablets

* fix(home): simplify layout structure and remove extra margin

* style: refresh button width grid stacking

* fix(layout): adjust padding for tablets

* style: unify section headlines to use consistent h2 tags

* style: improved theme selection

* fix: improve modal width on mobile using dvw

* fix: item alignment

* style: fix card margin

* fix: setting cards, same height

* fix: setting card layout
un-painted pushed a commit to un-painted-org/ESP-Miner that referenced this pull request May 5, 2025
@ciruz @un-painted
Update gitignore, simplify layout, fix refresh button UI, unify headl…
e369e4a 
…ines/margins, improve modal responsiveness and theme color selection (bitaxeorg#834)

* chore: ignore .DS_Store and system files in .gitignore

* fix(layout): reduce left padding on tablets

* fix(home): simplify layout structure and remove extra margin

* style: refresh button width grid stacking

* fix(layout): adjust padding for tablets

* style: unify section headlines to use consistent h2 tags

* style: improved theme selection

* fix: improve modal width on mobile using dvw

* fix: item alignment

* style: fix card margin

* fix: setting cards, same height

* fix: setting card layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutatrum mutatrum mutatrum approved these changes

@WantClue WantClue WantClue approved these changes

@mrv777 mrv777 Awaiting requested review from mrv777

Assignees
No one assigned
Labels
accepted This issue will be worked on design Design Enhancements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ciruz @STSMiner1 @mutatrum @WantClue
0