8000 refactor: Readable widget naming for debug window by s1Sharp · Pull Request #790 · bitcoin-core/gui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Readable widget naming for debug window #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor: Readable widget naming for debug window #790

wants to merge 1 commit into from

Conversation

s1Sharp
Copy link
@s1Sharp s1Sharp commented Jan 21, 2024

Fixed widget names in the debug window. Make it more developer friendly to avoid confusion inside Qt Designer.

@DrahtBot
Copy link
Contributor
DrahtBot commented Jan 21, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@s1Sharp
Copy link
Author
s1Sharp commented Jan 21, 2024 •
edited
Loading

Qt Designer view before changes:
image
Qt Designer view after changes:
image

And a few changes for other widget names that were not included in the screenshots.

Also property indent is unnessasary for QLabel: labelClientUserAgent

         <property name="indent">
          <number>10</number>
         </property>

This was referenced Jan 21, 2024
Merged
Merged
@hebasto
Copy link
Member
hebasto commented Jan 22, 2024

@s1Sharp

Thank you for your contribution!

However, I'm going to close this PR following our CONTRIBUTING Guide and to avoid unnecessary conflicts with other PRs.

@hebasto hebasto closed this Jan 22, 2024
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1Sharp @DrahtBot @hebasto
0