8000 Loadmempool fuzz corpus by rajarshimaitra · Pull Request #18 · bitcoin-core/qa-assets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Loadmempool fuzz corpus #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Loadmempool fuzz corpus #18

wants to merge 1 commit into from

Conversation

rajarshimaitra
Copy link

Some new fuzz corpus for loadmempool harness added in PR#19259

@rajarshimaitra rajarshimaitra mentioned this pull request Jun 25, 2020
Closed
@Crypt-iQ
Copy link
Contributor

I think you found a bug in github because there are 4608 changed files and the diff is +29, -0 so the counter might have overflowed. Do you have the ability to run afl-cmin on the files you have, then you can just 8000 get the smallest set of files that gives the same coverage.

@practicalswift
Copy link
Contributor

@Crypt-iQ I think the +29 -0 line numbers refer to text files only. Binary files are skipped in that calculation :)

BTW, the merge of this PR depends on the merge of the PR bitcoin/bitcoin#19259. Usually new seeds are added to this repo only after the corresponding fuzzer has been merged into Bitcoin Core master.

Before merging this seed PR I think it makes sense to run libFuzzer's -merge=1 -use_value_profile=1 to trim the corpus in this PR. That is the seed minimization technique we've used in the past and I think it makes sense to keep using it (instead of say afl-cmin) so that we get a consistent measure of coverage over time :)

Minimizing the corpus would be a matter of:

$ mkdir smaller-set-of-files-giving-the-same-coverage/
$ test/fuzz/validation_load_mempool \
      -merge=1 \
      -use_value_profile=1 \
      smaller-set-of-files-giving-the-same-coverage/ \
      all-4608-files-in-this-pr/
# Submit only the files in smaller-set-of-files-giving-the-same-coverage/ as part of this PR :)

@adamjonas adamjonas mentioned this pull request Dec 21, 2020
Merged
Base automatically changed from master to main March 18, 2021 14:47
@maflcko
Copy link
Contributor
maflcko commented Mar 18, 2021

Are the inputs minimized already?

@maflcko
Copy link
Contributor
maflcko commented Apr 9, 2021

Closing for now due to inactivity

@maflcko maflcko closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajarshimaitra @Crypt-iQ @practicalswift @maflcko
0