rpc: Avoid useless mempool query in gettxoutproof #19589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on feedback by @jnewbery in #19556 (comment) |
Merged
promag
reviewed
Jul 26, 2020
fa612a7 to
fadd84b
Compare
|
Addressed all feedback |
|
utACK fa5979d Nice tidy-up. Thanks Marco! |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
approved these changes
Jul 26, 2020
This was referenced Jul 26, 2020
|
Code review ACK fa5979d. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 28, 2020
fa5979d rpc: Avoid useless mempool query in gettxoutproof (MarcoFalke) fa1f7f2 rpc: Style fixups in gettxoutproof (MarcoFalke) Pull request description: `GetTransaction` implicitly and unconditionally asks the mempool global for a transaction. This is problematic for several reasons: * `gettxoutproof` is for on-chain txs only and asking the mempool for on-chain txs is confusing and minimally wasteful * Globals are confusing and make code harder to test with unit tests Fix both issues by passing in an optional mempool. This also helps with bitcoin#19556 ACKs for top commit: hebasto: re-ACK fa5979d jnewbery: utACK fa5979d promag: Code review ACK fa5979d. Tree-SHA512: 048361b82abfcc40481181bd44f70cfc9e97d5d6356549df34bbe30b9de7a0a72d2207a3ad0279b21f06293509b284d8967f58ca7e716263a22b20aa4e7f9c54
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 15, 2021
Summary: > GetTransaction implicitly and unconditionally asks the mempool global for a transaction. This is problematic for several reasons: > > - gettxoutproof is for on-chain txs only and asking the mempool for on-chain txs is confusing and minimally wasteful > - Globals are confusing and make code harder to test with unit tests > > Fix both issues by passing in an optional mempool. This also helps with [[bitcoin/bitcoin#19556 | core#19556]] This is a backport of [[bitcoin/bitcoin#19589 | core#19589]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D9783
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTransactionimplicitly and unconditionally asks the mempool global for a transaction. This is problematic for several reasons:gettxoutproofis for on-chain txs only and asking the mempool for on-chain txs is confusing and minimally wastefulFix both issues by passing in an optional mempool. This also helps with #19556