refactor: wallet, remove global 'ArgsManager' dependency #26889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 13, 2023
561f9ce to
d5f494d
Compare
2544bda to
928c17d
Compare
23e0d99 to
e619065
Compare
This was referenced Jan 18, 2023
|
Awesome. Approach ACK |
This was referenced Jan 19, 2023
|
Concept ACK |
|
Feedback tackled. |
hebasto
approved these changes
Feb 15, 2023
d90b54b to
fa1ce3d
Compare
hebasto
approved these changes
Feb 15, 2023
|
@achow101 can you take a look here |
achow101
reviewed
Feb 15, 2023
we are not using it anymore
Since we no longer store a ref to the global `ArgsManager` inside the wallet, we can move the util/system.h include to the cpp. This dependency removal opened a can of worms, as few other places were, invalidly, depending on the wallet's header including it.
fa1ce3d to
52f4d56
Compare
|
Updated per feedback. Thanks. |
hebasto
approved these changes
Feb 17, 2023
|
ACK 52f4d56 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 17, 2023
…pendency 52f4d56 refactor: remove <util/system.h> include from wallet.h (furszy) 6c9b342 refactor: wallet, remove global 'ArgsManager' access (furszy) d8f5fc4 wallet: set '-walletnotify' script instead of access global args manager (furszy) 3477a28 wallet: set keypool_size instead of access global args manager (furszy) Pull request description: Structurally, the wallet class shouldn't access the global `ArgsManager` class, its internal behavior shouldn't be coupled to a global command line args parsing object. So this PR migrates the only two places where we depend on it: (1) the keypool size, and (2) the "-walletnotify" script. And cleans up the, now unneeded, wallet `ArgsManager` ref member. Extra note: In the process of removing the args ref member, discovered and fixed files that were invalidly depending on the wallet header including `util/system.h`. ACKs for top commit: achow101: ACK 52f4d56 TheCharlatan: Re-ACK 52f4d56 hebasto: re-ACK 52f4d56 Tree-SHA512: 0cffd99b4dd4864bf618aa45aeaabbef2b6441d27b6dbb03489c4e013330877682ff17b418d07aa25fbe1040bdf2c67d7559bdeb84128c5437bf0e6247719016
This was referenced Feb 19, 2023
|
Found an issue where @MarcoFalke mentioned the need of removing gArgs from dfferent places and @ryanofsky's comment regarding the GUI specifically, which seem very interesting so I wanted to add the links here. |
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
May 11, 2023
…rom blockstorage 5ff63a0 refactor, blockstorage: Replace stopafterblockimport arg (TheCharlatan) 18e5ba7 refactor, blockstorage: Replace blocksdir arg (TheCharlatan) 02a0899 refactor, BlockManager: Replace fastprune from arg with options (TheCharlatan) a498d69 refactor/iwyu: Complete includes for blockmanager_args (TheCharlatan) f0bb102 refactor: Move functions to BlockManager methods (TheCharlatan) cfbb212 zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier (TheCharlatan) 8ed4ff8 refactor: Declare g_zmq_notification_interface as unique_ptr (TheCharlatan) Pull request description: The libbitcoin_kernel library should not rely on the `ArgsManager`, but rather use option structs that can be passed to the various classes it uses. This PR removes reliance on the `ArgsManager` from the `blockstorage.*` files. Like similar prior work, it uses the options struct in the `BlockManager` that can be populated with `ArgsManager` values. Some related prior work: bitcoin/bitcoin#26889 bitcoin/bitcoin#25862 bitcoin/bitcoin#25527 bitcoin/bitcoin#25487 Related PR removing blockstorage globals: bitcoin/bitcoin#25781 ACKs for top commit: ryanofsky: Code review ACK 5ff63a0. Since last ACK just added std::move and fixed commit title. Sorry for the noise! mzumsande: Code Review ACK 5ff63a0 Tree-SHA512: 4bde8fd140a40b97eca923e9016d85dcea6fad6fd199731f158376294af59c3e8b163a0725aa47b4be3519b61828044e0a042deea005e0c28de21d8b6c3e1ea7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structurally, the wallet class shouldn't access the global
ArgsManagerclass, its internal behavior shouldn't be coupled to a global command line args parsing object.So this PR migrates the only two places where we depend on it: (1) the keypool size, and (2) the "-walletnotify" script. And cleans up the, now unneeded, wallet
ArgsManagerref member.Extra note:
In the process of removing the args ref member, discovered and fixed files that were invalidly depending on the wallet header including
util/system.h.