8000 msvc: Provide `ObjectFileName` explicitly by hebasto · Pull Request #27687 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

msvc: Provide ObjectFileName explicitly #27687

New issue
Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

msvc: Provide ObjectFileName explicitly #27687

merged 1 commit into from
May 19, 2023

Conversation

hebasto
Copy link
Member
@hebasto hebasto commented May 17, 2023 •
edited
Loading

This PR is a follow-up to #26715.

Fixes intermittent MSVC link errors.

@DrahtBot
Copy link
Contributor
DrahtBot commented May 17, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK sipsorcery

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake
Copy link
Member

Can you explain what the issue currently is, and why this is the right fix (as opposed to bitcoin-core/gui#729)? Seems odd to have intermittent link failures.

@hebasto
Copy link
Member Author
hebasto commented May 17, 2023

Can you explain what the issue currently is, and why this is the right fix

The issue is the file name conflict.

See https://api.cirrus-ci.com/v1/task/6646912535756800/logs/build.log:

C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(1098,5): warning MSB8027: Two or more files with the name of util.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are ..\..\src\wallet\test\util.cpp, ..\..\src\qt\test\util.cpp. [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]

as opposed to bitcoin-core/gui#729

Well, it was a blind shot... But the code change was correct and actual an improvement.

@hebasto
msvc: Provide ObjectFileName explicitly
b8ed951 
Should fix intermittent MSVC link errors.
@hebasto hebasto marked this pull request as ready for review May 17, 2023 14:23
@hebasto
Copy link
Member Author
hebasto commented May 17, 2023

MSVC build is free from MSB8027 now.

@fanquake fanquake requested a review from sipsorcery May 18, 2023 10:34
@hebasto
Copy link
Member Author
hebasto commented May 19, 2023

Friendly ping @sipsorcery :)

@sipsorcery
Copy link
Contributor

ACK b8ed951.

Same object file name change has to be done in other places in the msvc build and doesn't affect the final build artifcat.

@DrahtBot DrahtBot removed the request for review from sipsorcery May 19, 2023 11:31
@fanquake fanquake merged commit fc4bee3 into bitcoin:master May 19, 2023
@hebasto hebasto deleted the 230517-object branch May 19, 2023 11:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 19, 2023
@fanquake
Merge bitcoin#27687: msvc: Provide ObjectFileName explicitly
f030853 
b8ed951 msvc: Provide `ObjectFileName` explicitly (Hennadii Stepanov)

Pull request description:

  This PR is a follow-up to bitcoin#26715.

  Fixes intermittent MSVC link [errors](https://cirrus-ci.com/task/6646912535756800).

ACKs for top commit:
  sipsorcery:
    ACK b8ed951.

Tree-SHA512: 4319ecf61b578ce66d240998d089b9bb0a42f89dcfcb1a73f648cd3915f566c773721dcff1feba27d393a743d121334ccb890b1a519173e35a156d6135821ef4
@bitcoin bitcoin locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sipsorcery sipsorcery sipsorcery approved these changes

Assignees
No one assigned
Labels
Build system Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @DrahtBot @fanquake @sipsorcery
0