p2p: Log addresses of stalling peers #27761
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
1 task
2c3235d to
5421304
Compare
ajtowns
reviewed
May 26, 2023
This allows node operators that have the -logips option enabled to better identify potentially misbehaving peers and maybe ban them.
5421304 to
fb02a3c
Compare
|
tACK fb02a3c. nice to have this! cross checked locations where we'd like inbound peer/disconnection peeraddr logging. |
|
github ACK fb02a3c |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 26, 2023
fb02a3c p2p: Log addresses of stalling peers (Martin Zumsande) Pull request description: This was suggested in bitcoin#27705 by ArmchairCryptologist. It allows node operators that have the `-logips` option enabled to better identify potentially misbehaving peers and maybe ban them. This is especially helpful in case of inbound peers for which (dis)connections aren't logged per default, so it's impossible to use the debug log to connect their `nodeId` to an address unless the very noisy `net` debugging is enabled. In case of outbound peers for which the address is potentially logged when establishing the connection, this just adds some convenience. ACKs for top commit: stratospher: tACK fb02a3c. jamesob: github ACK bitcoin@fb02a3c 0xB10C: Untested ACK fb02a3c instagibbs: utACK fb02a3c Tree-SHA512: 2080f794c715bd36143405828b4b0e1be859095caf8f8a0c20dd2a4b64d192d78fee0fa350a2bb7c39848718332c4dd4d8edb2cc8d22095b65afe710591f7ccb
|
May I suggest a fine pairing? #27826 |
|
Yes, I'll review soon! It's been on my list anyway but I got distracted by other things... |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 16, 2023
This allows node operators that have the -logips option enabled to better identify potentially misbehaving peers and maybe ban them. Github-Pull: bitcoin#27761 Rebased-From: fb02a3c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested in #27705 by ArmchairCryptologist.
It allows node operators that have the
-logipsoption enabled to better identify potentially misbehaving peers and maybe ban them.This is especially helpful in case of inbound peers for which (dis)connections aren't logged per default, so it's impossible to use the debug log to connect their
nodeIdto an address unless the very noisynetdebugging is enabled.In case of outbound peers for which the address is potentially logged when establishing the connection, this just adds some convenience.