refactor: Fix timedata includes #29361
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
There was a problem hiding this comment.
Concept ACK, but I think there are a couple more include changes that should be made as per my diff in #28956 (review)
faa899c to
fad0faf
Compare
There was a problem hiding this comment.
nit: iwyu suggests
chain.h should add these lines:
namespace Consensus { struct Params; }
chain.h should remove these lines:
- #include <consensus/params.h> // lines 10-10
There was a problem hiding this comment.
Going to leave removal of further includes to a follow-up
|
ACK fad0faf |
Remove unused includes. Also, fixup comments, see https://github.com/bitcoin/bitcoin/pull/28956/files#r1464827885. Also, add missing includes to
chain.hwhile touching it.