net: Address outstanding review comments from PR20721 #21198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reviewing #20721 @ajtowns @amitiuttarwar @MarcoFalke. Here are your suggested changes.
EDIT: That suggestion was taken in #21015, which has now been merged. |
maflcko
reviewed
Feb 16, 2021
3589baa to
ae12c65
Compare
ajtowns
reviewed
Feb 18, 2021
240ff15 to
57d0224
Compare
|
Rebased on master to pick up fix for interface_zmq.py in #21008. |
57d0224 to
11ef360
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with 8000 the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
11ef360 to
caa4a3f
Compare
|
Rebased and moved out of draft. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
- rename to ShouldRunInactivityChecks (bitcoin#20721 (comment)) - take optional time now (bitcoin#20721 (comment)) - call from within InactivityChecks (bitcoin#20721 (comment)) - update comment (bitcoin#20721 (comment)) - change ordering of inequality (bitcoin#20721 (comment))
|
Rebased |
caa4a3f to
5ed535a
Compare
|
Code review ACK 5ed535a |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 1, 2021
…20721 5ed535a [net] Changes to RunInactivityChecks (John Newbery) Pull request description: Updates the RunInactivityChecks() function: - rename to ShouldRunInactivityChecks (bitcoin#20721 (comment)) - take optional time now (bitcoin#20721 (comment)) - call from within InactivityChecks (bitcoin#20721 (comment)) - update comment (bitcoin#20721 (comment)) - change ordering of inequality (bitcoin#20721 (comment)) - ~make inline (bitcoin#20721 (comment) ACKs for top commit: laanwj: Code review ACK 5ed535a Tree-SHA512: e6ac8e8cce5cddc84a52a40c908634c25f58be74512d642840d7bd7fa65c3d90a0f46cc19e4865b3fae7c933138247f58356167a60a5c519305cfd6d05e51f51
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 2, 2022
Summary: - rename to ShouldRunInactivityChecks - take optional time now - call from within InactivityChecks - update comment - change ordering of inequality This is a backport of [[bitcoin/bitcoin#21198 | core#21198]] Depends on D10954 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10955
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the RunInactivityChecks() function:
make inline (Net: Move ping data to net_processing #20721 (comment))